fix(docs) :: remove DSN=DuckDB from the database_url default - #1421
Conversation
|
Maybe the docs should be clearer, but dsn=duckdb is the default in our duckdb docker images |
|
it seems very unobvious thing to put in the configuration page fro all of SQLPage. furthermore, it seems silly that SQLPage is explaining that it overwrite the default db param for a docker image specifically designed for DuckDB. from the perspective of an end user this is an exception to the rule (and not another default) that only applies to consumers of the docker image (and even then, the docker image with not sure where the Docker description is pulled from tho. it doesn't seem to be codified in the repo |
|
I am open to a better wording in the documentation, but it must be concise and helpful. We can just state "context-dependent, see below" and add a short section later in the file. |
`create_default_database` only ever builds a `sqlite://` URL, so this isn't a possible default
2242c1d to
3a49cec
Compare
|
I read through the docs again, and I moved it as a line in the |
create_default_databaseonly ever builds asqlite://URL, so this isn't a possible defaultSQLPage/src/app_config.rs
Lines 633 to 676 in 109b20d