tests(sql) :: add tests that check rewriter guards and what reaches the database - #1422
Merged
Merged
Conversation
81reap
marked this pull request as ready for review
September 2, 2026 02:40
lovasoa
approved these changes
Sep 2, 2026
lovasoa
marked this pull request as draft
September 2, 2026 21:31
81reap
marked this pull request as ready for review
September 2, 2026 21:39
lovasoa
marked this pull request as draft
September 2, 2026 21:50
81reap
marked this pull request as ready for review
September 2, 2026 23:35
lovasoa
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emulated_concat_keeps_nested_call_per_rowemulated_functionrecognisesconcat, and asqlpage.call nested inside it stays a per-row callonly_nested_run_sql_requires_bufferingmust_buffer_rowsis false unless a computed column callssqlpage.run_sqldistinct_is_rejected_only_when_a_projection_is_computed_by_sqlpageselect_item_contains_sqlpage. PlainSELECT DISTINCTstill reaches the database. Only a SQLPage-computed projection is an errorboolean_literal_stays_a_literal_in_the_static_simple_selectValue::Booleanarm.true as fixed_top_menubecomes a JSON boolean, not a stringwith_and_limit_clauses_are_never_folded_into_a_constant_rowhas_static_simple_select_shaperejectsWITHandLIMIT. TheINSERTinside the CTE still runs and keeps its bindinga_database_operand_keeps_the_whole_projection_in_the_databaseprojection_is_per_row.'x' || now()is sent to the database whole, not splitconcat_operator_is_rewritten_to_a_function_only_on_sql_serverSupportedDatabase::Mssqlguard indatabase_lowering.||becomesCONCATon SQL Server and stays||on Postgresmodifiers_on_a_sqlpage_function_are_rejectedrecognize_sqlpage_function.OVER,FILTER,IGNORE NULLSandWITHIN GROUPon asqlpage.call are errors, not silently dropped