Repository navigation
fix(ci): only upload breakpad symbols when a symbol server is configured - #5
Merged
Merged
Conversation
The fork has no BREAKPAD_SYMBOL_SERVER variable, so upload_symbols.py was called with an empty URL and every Build Release failed with "ValueError: unknown url type: ''". Only pass --breakpad-dump when the variable is set; --symbol-files still produces the separate symbol files and PDBs. Also bump actions/checkout v6 -> v7 and actions/cache v5 -> v6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build Releasefails on every push to1.12-dev(andmaster), on both Linux and Windows:The workflow comes from upstream, where
vars.BREAKPAD_SYMBOL_SERVERpoints to AlliedModders' symbol server. This fork has no such variable, so--breakpad-dumpmakes AMBuild callupload_symbols.pywith an empty URL.--breakpad-dumpwhenvars.BREAKPAD_SYMBOL_SERVERis set.--symbol-filesis kept, so separate symbol files and the PDB artifact are still produced, and the release packages are unchanged.actions/checkoutv6→v7andactions/cachev5→v6in both workflows (off the deprecated Node.js 20 runtime).Targets
1.12-dev, the branch the fork builds from (same base as #4).Test plan
PR Checkspass on this PRBuild Releaseon1.12-devsucceeds and publishes the Linux and Windows packages (this workflow only runs on push, so it can't run on the PR)🤖 Generated with Claude Code