Repository navigation
Add linux64 gamedata (CS:S x86_64) - #50
Merged
Merged
Conversation
Script_ClientPrint keeps its symbol on x86_64. Without it the detour can't be
set up there ("Failed to setup ClientPrint() detour!").
Note: the player argument is an HSCRIPT pointer declared as int, so on x86_64
DHooks reads its low 32 bits; the plugin only compares it to 0, which stays
correct in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of moving our ZE server to the CS:S x86_64 build (srcdslab/sourcemod#9, srcdslab/metamod-source#4). SourceMod reads
"linux64"keys there and doesn't fall back to"linux", so theClientPrintdetour couldn't be set up (Failed to setup ClientPrint() detour!).Changes
ConsoleChatManager.games.txt:"linux64" "@_ZL18Script_ClientPrintP9HSCRIPT__iPKc"(the same symbol exists in the x86_64server_srv.so, build 11003710).Note: the first argument is an
HSCRIPTpointer declared asint, so on x86_64 DHooks reads its low 32 bits. The plugin only compares it to 0, which stays correct in practice. Switching it toobjectptrwould break plugins thatDHookGetParamit.Testing
On CS:S x64:
Successfully detoured ClientPrint().