[Rushaway]

Summary

A failed query hands its DataPack to CreateTimer(..., TIMER_FLAG_NO_MAPCHANGE) for the retry. A map change kills that timer, so the pack was never given back to a request and never deleted: one leaked DataPack per retry pending at map end. TIMER_DATA_HNDL_CLOSE / CreateDataTimer cannot fix it, they close the pack when the timer ends and these packs are reused after the timer fires (they become the data of the next query).

Changes

• SQL_ScheduleRetry(callback, pack) replaces the 10 CreateTimer(g_cvar_SQLRetryTime...) calls that carry a pack. It records the pack in g_alRetryPacks before creating the timer.
• SQL_BeginRequest(timer, pack, counters, client) (the former ResetRetryBudget) is still the first call of the 10 request entry points. When timer is a real handle the retry timer fired, so the pack goes back to the request and is removed from the registry; otherwise it is a new request and gets its fresh retry budget as before.
• OnMapEnd calls SQL_ClearPendingRetries(), which deletes the packs whose timer is about to die with the map. A pack is in the registry only while its timer is pending, so nothing in flight is freed.
• A pending replace insert also owns a reservation of the list capacity (g_smReplacePendingTriggers). Its retry dying with the map would have leaked it too, so OnMapEnd also calls ClearReplaceReservations(). An insert still in flight is not affected: its callback only decrements for a reservation it finds.
• The replace list retry (SQLSelect_Replace) and the startup retries carry no pack and are unchanged.

Testing

Compiled with spcomp 1.12.0.7255 against the same dependency set as CI, no warnings. Not exercised on a live server, the runtime steps below are for the reviewer.

• With the database down, trigger a query (for example change a tag color) and change the map before the retry fires: no error in sm logs, and the handle count (sm_dump_handles before and after) does not grow over repeated cycles.
• A retry that fires normally (database back before the timer) still runs its query and the tag is saved.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.