Repository navigation
refactor: drop stock from used functions, use delete instead of CloseHandle - #103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Style cleanup, no behavior change.
Changes
stockfrom the 63 functions ofCustomChatColors.sp.stockmeans "may be left out when unused", which only makes sense in an include; all of them are used, and the build would have warned if one were not.CloseHandle(menu)becomesdelete menuin the 16 menu handlers.view_as<CCC_ColorType>(CCC_...Color)that cast an enum member to its own enum inHook_UserMessage. The one onGetNativeCellis kept, it converts anint.The changes are mechanical and were applied by script (one regex per category); the file diff is only the removed
stockprefixes, the 16 handle closes and the 3 casts.Testing
Compiled with spcomp 1.12.0.7255 against the same dependency set as CI, no warnings. Not exercised on a live server.
sm logs.🤖 Generated with Claude Code