Repository navigation
refactor: use SourceMod 1.12 methodmaps - #3
Merged
Merged
Conversation
- Replace legacy natives with their SourceMod 1.12 methodmap equivalents: - `GameData` (`new GameData()`, `.GetOffset()`/`.GetAddress()`/`.GetKeyValue()`) - Retype the affected handles and callback parameters (`Handle` -> `ConVar`, `Event`, `Menu`, `KeyValues`, ...) - The gamedata handle is now loaded once, freed after use, and the plugin fails cleanly if the gamedata file is missing. `version` used to be `SOURCEMOD_VERSION`; it is now an explicit `"1.0.1"` so it can be bumped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Add `#pragma newdecls required` and convert the remaining old-style syntax (`new`/`decl`, `String:`/`Float:` tags, untyped functions and parameters, `Tag:` casts) to new-style declarations Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GameData(new GameData(),.GetOffset()/.GetAddress()/.GetKeyValue())Handle->ConVar,Event,Menu,KeyValues, ...)versionused to beSOURCEMOD_VERSION; it is now an explicit"1.0.1"so it can be bumped.#pragma newdecls requiredand convert the remaining old-style syntax (new/decl,String:/Float:tags, untyped functions and parameters,Tag:casts) to new-style declarationsWhy
Methodmaps are the API SourceMod documents and maintains; the procedural natives only remain for backward compatibility. The typed handles also let the compiler catch handle misuse. No behaviour change is intended.
Test plan
🤖 Generated with Claude Code