Repository navigation
Support CS:S x86_64 - #29
Merged
Merged
Conversation
cmer81
added
x86_64
Member
Author
|
The plugin is now built with SourceMod 1.13 includes (64-bit |
- Read ScriptVariant_t::m_pszString with LoadAddressFromAddress: it was read as an Int32, which truncates the pointer on x86_64 (m_type stays at +8, the value union is 8 bytes on both). - gamedata: linux64 signatures (same symbols as linux). - CI: build with SourceMod 1.13.0.7427 (production) for 64-bit Address. Checked on CS:S x86 and x86_64 (build 11003710) with VScript Convars.SetValue: int, float and string values are decoded the same and rcon_password is blocked.
Rushaway
force-pushed
the
feat/linux64
branch
from
October 28, 2026 10:41
4e24e83 to
856f229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of moving our ZE server to the CS:S x86_64 build (SourceMod 1.13.0.7427 + srcdslab/sourcemod#9 + srcdslab/metamod-source#4).
Problems on x86_64
Detour_SetValuereadsScriptVariant_t::m_pszStringwithLoadFromAddress(..., NumberType_Int32), which truncates the pointer.linux64keys.Changes
LoadAddressFromAddress.m_typestays at +8: the value union is 8 bytes on both architectures (it hasfloat64/uint64members, seepublic/vscript/variant.h).ScriptVariant_thas a user-declared copy constructor, so it's passed by hidden reference andobjectptris right on both.linux64signatures (same symbols aslinux).Address/LoadAddressFromAddress).Testing
On CS:S build 11003710, x86 and x86_64, through VScript
script Convars.SetValue(...): int (sv_gravity 300), float (sv_airaccelerate 12.5) and string (mp_timelimit "25") values are decoded and filtered the same way on both, andrcon_passwordis blocked.