Repository navigation
fix: ignore clients not in game in OnClientDisconnect - #31
Merged
Merged
Conversation
VIP_IsClientVIP throws a native error ('Client N is not connected') when
the client never reached in-game state, flooding the logs.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnClientDisconnect fires for players that disconnect before being in game (timeout, rejection, map change). Calling VIP_IsClientVIP on them makes VIP-Core's CheckValidClient throw
Client N is not connected, producing a lot of error logs.Add an IsClientInGame guard (such a player can't have received the test VIP anyway) and bump version to 2.1.1.
Compiled with spcomp 1.13.0.7427, no errors or warnings.