Repository navigation
ci: replace SourceKnight with native GitHub Actions workflow - #8
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo is a monorepo (Go server + SourcePawn client plugin + Gatsby docs). Only the SourceMod plugin build (the
clientjob) used SourceKnight (maxime1907/action-sourceknight); theserveranddocjobs already used native GitHub Actions and are untouched aside from a version bump onactions/checkoutfor consistency..github/workflows/build.ymlwith.github/workflows/ci.yml.rumblefrog/setup-sp+spcompbuild (SourceMod 1.12, matchingsourceknight.yaml).server(Go) anddoc(Gatsby) jobs' logic unchanged.sm-plugin-AdminRoomtemplate migration:tagjob now checks out the repo before runningrickstaa/action-create-tag(it runs local git commands and fails without a checkout).releasejob'sif:explicitly checksneeds.tag.result == 'success' || needs.tag.result == 'skipped'combined withalways(), so release doesn't silently skip on a direct tag push (wheretagis skipped).depsdirectory is created up front in the dependency-install step.sourceknight.yamland removed the now-unused# Sourceknight/.sourceknightentries from.gitignore(the*.smxignore rule was already present elsewhere in the file, so it was kept).common/folder exists in this repo, so no "copy common into package" step was added.Plugins compiled
client/Source-Chat-Relay.spaddons/sourcemod/plugins/Source-Chat-Relay.smxDependencies cloned
socket.incat repo rootaddons/sourcemod/scripting/include/(containsmulticolors.incandmulticolors/subfolder)bytebuffer.incandbytebuffer_es.incat repo root(The
sourcemodtar dependency insourceknight.yamlis handled byrumblefrog/setup-sp@v1.3.1withversion: "1.12.x", same as before.)Local validation performed
Actually compiled the plugin locally with a SourceMod 1.12
spcompbinary, replicating exactly what the new CI build step does:--depth=1intodeps/..incfiles intoaddons/sourcemod/scripting/include/per the paths in the table above.spcomp -i include -i ../addons/sourcemod/scripting/include -o ../addons/sourcemod/plugins/Source-Chat-Relay.smx Source-Chat-Relay.spfromclient/.Result: compiled successfully with no errors (
Source-Chat-Relay.smx, ~30KB output, "Code size: 53116 bytes").Manual verification needed
server(Go/Node build) anddoc(Gatsby) jobs were not modified in substance (onlyactions/checkoutbumped tov7for consistency) since they don't use SourceKnight — please confirm these still build correctly, as they weren't re-validated locally as part of this SourceKnight-focused migration.releasejob's tar packaging (tar -czf ... Plugin Server) assumes both thebuild(Plugin) andserver(Server) artifacts are present, matching the pre-existing behavior — worth a real CI run to confirm the multi-artifact release still packages correctly end-to-end.