chore(ci): bump changesets/action from 1 to 2 - #1035
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [changesets/action](https://github.com/changesets/action) from 1 to 2. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@v1...v2) --- updated-dependencies: - dependency-name: changesets/action dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Not approved. This is a major changesets/action v1→v2 bump in the release workflow; the step still uses the v1 version/title/commit inputs and GITHUB_TOKEN env, so a human should confirm v2 compatibility before merge. No additional reviewers assigned (frahlg is already requested). Bugbot was not present, so that signal was skipped.
Sent by Cursor Approval Agent: Pull Request Router and Approver
miravoss26
left a comment
There was a problem hiding this comment.
Dependency bump, reviewed. Bumps changesets/action from v1 to v2 in .github/workflows/release.yml (the "Create or update Version Packages PR" step of the release workflow).
- No new permissions or secrets added in this diff — token scoping on the job is untouched.
- It's a major version bump on a release-critical workflow (this job creates/updates the version-packages PR that drives your release cut) — worth a human glance at changesets/action's v2 release notes for behavior changes before it runs for real, rather than treating this as a pure rubber stamp.
- CI green on the checks that ran for a workflow-only change.
Looks safe from a code/secret-exposure read, but flagging the major bump for a release-owner's eyes given what this workflow does. srcfl/ftw isn't on my merge allowlist either way.
|
Superseded by #1045. The tag bump on its own is not enough here: v2 renamed every input and output this step uses. #1045 carries the same v2 bump with the full rename, plus a test pinning the output name to the action major. Closing this one. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Dependabot #1035 moved the tag alone. v2 renamed every input and output, so the tag on its own leaves five silent regressions behind. - `version`, `title` and `commit` are gone. Unknown `with:` keys only warn, so the action would have fallen back to a bare `changeset version` and dropped the `npm install --package-lock-only` half of `version-packages`, drifting package-lock.json off package.json. - v2 no longer reads the GITHUB_TOKEN environment variable. The token is an input now; without it the action authenticates as `github.token`, whose pushes start no workflows, so the Version Packages PR would arrive with no checks. CI_TOKEN exists for exactly that reason. - v2 pushes through the GitHub API by default, which would have made the CI_TOKEN auth header installed one step earlier dead weight. `push-with-git-cli: true` keeps the existing credential path. - `hasChangesets` is `has-changesets`. The stale name reads as empty, so the five stable-promotion guards comparing it to 'false' would never fire: a `workflow_dispatch` promotion would go green having skipped the GHCR write checks, the tag and the draft release. @changesets/cli is already ^3.0.1, which is what v2 requires. release-metadata.test.mjs pinned the old input name; it now pins the new one, plus the output name against the action major that publishes it, so the tag and the expressions reading it cannot drift apart again. Claude-Session: https://claude.ai/code/session_017J8AuNpMQpExYq5qG5iQe9 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>


Bumps changesets/action from 1 to 2.
Release notes
Sourced from changesets/action's releases.
... (truncated)
Changelog
Sourced from changesets/action's changelog.
... (truncated)
Commits
8488615v2.1.1d7669c8Version Packages (#722)da1ea29Fix typo in renamed inputs (#721)7545547Version Packages (#719)3043070Prevent test warning annotations (#720)3b7c71cAdd back cwd input (#718)6f58ba3Update pr-status message links to new faq (#716)e52ce9eVersion Packages (#715)78fdc6bExit pre mode (#714)187a104Update deps for stable (#709)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)