Skip to content

feat(web): simple forecast status with details on demand - #1278

Merged
frahlg merged 1 commit into
masterfrom
feat/forecast-ui
Sep 17, 2026
Merged

frahlg merged 1 commit into
masterfrom
feat/forecast-ui

Conversation

@frahlg

@frahlg frahlg commented Sep 17, 2026

Copy link
Copy Markdown
Member

The ML twins panel mixed Energyplan learning state with older model statistics and quality bars. More now shows two simple forecast cards with a status, elapsed learning days when a recorded start exists, and a Details button. The cards are available in simple mode, above Advanced.

Details contains model state, training dates, the household profile, explained local-model statistics and relearning. The view removes the training-quality percentage bars. Disclosure state and keyboard focus survive refreshes; polling runs only while More and the browser tab are visible.

Healthy requires learning.health: healthy, a ready model and a valid recent training timestamp. Degraded health takes priority. Missing health fields produce a neutral Ready state; a missing start date produces no day count. Paired backend: #1283 supplies learning.health and learning.health_reason, including storage failures; it currently depends on #1282. This UI handles older servers without those fields. Health reports operation, not measured forecast accuracy.

Validation:

  • All 610 web tests pass, including disclosure/focus, age, health, stale data, polling and reset failure cases.
  • PATH=/opt/homebrew/bin:$PATH make verify passes with the installed modern Bash.
  • Rendered the cards at desktop and 390 px width, in dark/light themes, with details, degraded health and missing start/health data. Also checked the actual More layout in simple mode. Preview uses fixtures and cannot send device commands.

Fredrik reviewed the rendered preview and approved merging on 2026-09-17. Local preview: http://127.0.0.1:8196/#more (sample data). No box deployment.

Related: #1177 touches polling in twins.js; its twins.js version is identical to master at this PR's base. This change retains hidden-tab suspension and further limits polling to More.

@frahlg
frahlg marked this pull request as ready for review September 17, 2026 07:24
@frahlg
frahlg merged commit 792cd21 into master Sep 17, 2026
13 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-17T07:27:27.686118Z c3aeff2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant