feat(web): show car charge levels and upcoming charging in the site plan - #1295
Merged
Merged
Conversation
frahlg
force-pushed
the
feat/vehicle-charge-limit-ui
branch
from
September 17, 2026 14:14
dc9f53f to
b7450a4
Compare
frahlg
force-pushed
the
feat/vehicle-charge-limit-ui
branch
from
September 17, 2026 15:40
b7450a4 to
8ff18ac
Compare
frahlg
marked this pull request as ready for review
September 17, 2026 16:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A charging goal should show what FTW knows about the car and when it plans to charge. This adds a “Car’s charge limit” goal, shows the current battery level and car limit with their sources, and adds readable charging windows to the car view, Overview and the household Plan.
Existing percentage goals keep their values. The new goal choice requires Core’s
vehicle_limit_goal_supportedflag from merged #1297. The car-limit goal uses only Core’sgoal_completefor completion; a 100% planning fallback or estimated level never confirms it. Charge now still sends a manual hold without a percentage release cap.The level display reads fresh
vehicle_socandvehicle_charge_limitseparately from the controller’scurrent_socestimate. When car data is missing, users can correct the current estimate and see that the car limit is unknown. There is no manual car-limit hint in Core yet; this UI does not invent one or reuseschedule.socfor it. Pending writes, restart persistence failures and unavailable readings remain visible.The shared timeline shows upcoming windows, local dates, and planned energy. Pending, outdated, paused, manual and unavailable states do not display old windows as a current schedule. Energy clipped to the visible period is marked approximate. The household chart and briefing now sum
loadpoint_power_wacross cars, falling back toloadpoint_wfor older plans without counting both.Validation: 638 web tests pass;
make verifypasses. Rendered car and household-plan views were checked with labeled local sample data, including mobile at 390 px, desktop, light/dark themes, missing car data, pending plans, current-level editing and percentage-goal preservation. The corrected preview includes the whole car plan view. No physical charging or box install was performed.Draft while Fredrik reviews the revised UI. Core #1297 and storage #1300 are already on this branch’s base. Related EV work: #1293. The visibility polling code from open #1177 is preserved; these changes extend its existing fetch batch and plan rendering. Index edits are confined to plan content and do not alter the map assets from #1219 or settings asset from #1003.