fix(ops): wait through a native migration restart - #1363
Merged
Merged
Conversation
A Core restart closes the API socket. ftwctl treated that reset as a failed install and rolled the new process back within a second, even when the new version had already booted. The readiness wait now treats the disconnect as not ready yet.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ftwctl migrate-nativetreated the API socket closing during Core's restart as a failed install and rolled the new process back within a second.homelab-rpi,v0.132.0-beta.1had already booted (migrations complete, HTTP listening) when that happened. The oldv3.8.0-beta.1service was restored.ConnectionResetErrorand timeouts as "not ready yet", andAPI.openturns a raw socket error into the same handled error. A regression test keeps a booting native Core in place across one restart disconnect.Test
python3 scripts/test_ftwctl.py— 10 tests, ok.