Repository navigation
Redirect Get Feedback to the canonical subscript.to origin - #4
Merged
Merged
Conversation
Closes #2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Manual verificationCI can't cover these because they need the deployed site and a real Subscript account.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get Feedback redirected users to
write.subscript.toafter uploading their draft, where SSO login fails. It now always lands on the canonical Subscript site (subscript.to).Root cause
getFeedbackinapp/src/App.tsxPOSTs to the relative path/write/feedbackand then calledwindow.location.assign(result.redirect_url)directly. When the editor is served fromwrite.subscript.to, a relativeredirect_url(or one the server built from the request host) resolves towrite.subscript.to, notsubscript.to.Change
feedbackRedirectUrl(app/src/lib/feedback.ts) resolves the returned redirect against the configured Subscript homepage (config.homepage, defaulthttps://subscript.to):getFeedbackuses the helper before navigating.User impact
After clicking Get Feedback on
write.subscript.to, users land onsubscript.to, where SSO login works.Tests
app/src/lib/feedback.test.tscovering relative, editor-host, foreign-origin, and embedded-on-homepage redirects.pnpm run lintandpnpm run test(13 files, 41 tests) pass locally.Notes
Closes #2
Agents: claude-code (claude-opus-5-5)