feat: Add a helm-lint job to the build workflow - #635
Merged
Conversation
See hive-operator#743 which already tested this for Hive. helm lint validates the chart templates and, where a values.schema.json exists, the default values against it.
Techassi
approved these changes
Aug 17, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
Approved in general, just one question.
Member
Spoiler alert: It won't work :) |
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
It works differently than I expected. Let's see |
Member
Be prepared for your signed commits to break: github/gh-stack#256 (reply in thread) |
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the
helm-lintjob from stackabletech/hive-operator#743 into the templatehelm lintvalidates the chart templates and, where avalues.schema.jsonexists, the default values against it. The chart cannot render without a registry overlay, becauseimage.repositoryis only set there, so both published registries are linted.Stacked on #634, which ports stackabletech/hive-operator#742.
This is my first time trying the stacked PR feature...so...no idea how that works until I try.