chore: Namespace the Helm defined templates with the chart name - #645
Open
lfrancke wants to merge 1 commit into
Open
chore: Namespace the Helm defined templates with the chart name#645lfrancke wants to merge 1 commit into
lfrancke wants to merge 1 commit into
Conversation
Helm shares one namespace for defined templates between a chart and all of its subcharts, so identically named ones collide under an umbrella Chart. A define name is fixed when Helm parses the template, so the chart name has to be substituted at generation time. That makes the three helper files and service.yaml Jinja templates. The call sites in the files each operator owns are not templated, so every generated PR needs a follow-up commit renaming them before it can merge. stackabletech/issues#882
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
reviewed
Sep 2, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
I generally approve, but I want to make sure we are happy with the choice of prefix:
- The current prefix (operator name), will result in keys like
airflow-operator.fullname - A different viable option would be to use "pretty string", which will result in keys like
airflow.fullname
I have no strong preference, I just wanted to bring it up.
Member
Author
|
Thanks. The prefix is purely internal, right? That's the whole point as far as I understand. So I'm fine with the current one but also have no strong preference. If I don't hear any different I'd like to merge it tonight so I can prepare the rollout. |
Member
Yeah it is (at least for 99% of use-cases). People could customize the Helm chart on their own, but then again, they can do whatever they want at this point.
Alright, then I wall call it done. |
Techassi
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#882 to make everything namespaced.
After rollout ALL (or some?) of these PRs should fail because some files in the operators will still reference the old defines and we now have a helm lint step in CI 🥳
So, I'd like to merge this, roll it out and I'll then amend each PR manually.