Repository navigation
Add configurable Axum buffered JSON body limits - #407
Draft
ChristianPavilonis wants to merge 2 commits into
Draft
ChristianPavilonis wants to merge 2 commits into
ChristianPavilonis wants to merge 2 commits into
Conversation
ChristianPavilonis
added this pull request to stack #408
October 6, 2026 21:02
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #406, which is based on #275. This implementation was explicitly authorized on the current hosting base at
3ab2209, without waiting for accepted #275 integration. No parent code was merged or rebased. Keep this PR draft until the later prerequisite rebase/re-audit and remaining acceptance work are complete.Changes
body.rs,lib.rsBody, exhaustiveBodyContentraw handoff, and external API fixturesPayloadTooLarge, sticky initial errors, and stateless cached rechecksBodyContentwithout changing provider policiesBreaking API:
BodyaddsManagedand becomes#[non_exhaustive]. Downstream exhaustive raw-Body matches must migrate to accessors orBody::into_contentand exhaustiveBodyContent, or add a raw-Body wildcard.Closes
Closes #393.
Part of #391. This PR remains draft until accepted-prerequisite integration and the remaining acceptance work below are complete.
Test plan
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"cargo check --all-targetsfor Fastly, Spin, and Cloudflare, plus core WASM checkcargo test -p edgezero-core --all-targets, 724 unit and 2 integration testscargo test -p edgezero-core --doc, 2 regular and 4 compile-fail tests; 13 existing examples ignoredcargo test -p edgezero-adapter-axum --all-targets --all-features, 192 unit, 13 contract, 16 subprocess teststests::json_body_limit_wire_content_length_and_chunkedexecuted separately and reportedokgit diff --checkFinal Rust commands checked one 25-file source fingerprint before and after execution. The plan records commands, counts, elapsed times, and local log paths. Local
/tmpartifacts are not durable CI evidence.Remaining gaps include dedicated above-8-MiB reconstruction, actual router app-state replacement dispatch, and router-only override wire cases. Media variants were tested at the configured 64-byte boundary rather than repeated for every default-size framing. The router-only test awaits outer cancellation, not an explicit inner blocking-worker join.
Fastly all-feature native tests could not link provider host ABI imports; portable Fastly tests passed 94. The standalone Viceroy version differs from the pinned version, and wasmtime/wasm-bindgen-test-runner were unavailable, so no provider-runtime certification is claimed. One inherited storage subprocess
selected-greetingassertion failed transiently during development, then passed individually and in subsequent full suites. It is unresolved, not classified as a reproduced baseline failure. Final native/workspace runs used no exclusions.Checklist
CLAUDE.mdconventions{id}syntaxedgezero_core