Skip to content

Updates to script and README for new proto value - #124

Open
clickboo wants to merge 1 commit into
mainfrom
boo-fix-script-readme
Open

clickboo wants to merge 1 commit into
mainfrom
boo-fix-script-readme

Conversation

@clickboo

@clickboo clickboo commented Oct 1, 2026 •

Copy link
Copy Markdown

Summary

  • The post-upgrade script and README wrote INIT on evaluationFilter.skipContainerTypes.
  • The script payload, comments, and Policy-as-Code example now use SKIP_INIT.

Test plan

  • shellcheck util-scripts/skip-init-container-evaluation/skip-init-container-evaluation.sh passes
  • Confirm a policy update against ACS 5.0 stores skipContainerTypes: ["SKIP_INIT"]

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 00dd2560-3a92-437a-a6c5-4902b32c3ab1

📥 Commits

Reviewing files that changed from the base of the PR and between 7fb988b and 1fac741.

📒 Files selected for processing (2)
  • util-scripts/skip-init-container-evaluation/README.md
  • util-scripts/skip-init-container-evaluation/skip-init-container-evaluation.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation

    • Updated the policy examples and script description to use SKIP_INIT as the container type to skip.
  • Bug Fixes

    • Corrected the evaluation filter so eligible policies skip SKIP_INIT containers.

Walkthrough

The script now sets skipContainerTypes to SKIP_INIT for eligible policies. The README description, update steps, and YAML example use the same value.

Changes

Skip init container evaluation

Layer / File(s) Summary
Update filter value and documentation
util-scripts/skip-init-container-evaluation/skip-init-container-evaluation.sh, util-scripts/skip-init-container-evaluation/README.md
The script sets the evaluation filter to SKIP_INIT. The README uses SKIP_INIT in its description, update steps, and YAML example.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1fac7

The script and documentation now use the intended API enum value consistently. No actionable merge-blocking risk is established; ACS 5.0 read-back validation remains a normal validation follow-up.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the script and README updates for the new proto value. It matches the main change.
Description check ✅ Passed The description accurately describes replacing INIT with SKIP_INIT and includes the test status. It relates directly to the changeset.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@clickboo
clickboo requested a review from vjwilson October 1, 2026 23:23
@vjwilson
vjwilson requested a review from dashrews78 October 2, 2026 13:15
@dashrews78

Copy link
Copy Markdown

any validation performed like say running it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants