[meetestherpeter]

Summary

Extend persistent TTL at write sites to prevent silent expiry

What was solved

#583 — [High] governor, timelock, and treasury_streams each write persistent storage without ever calling extend_ttl — a third, fourth, and fifth instance of the same gap already filed for reputation_badge (#119)

Add persistent TTL extension at every persistent write site in timelock, governor, and treasury_streams, following the PERSISTENT_TTL_THRESHOLD/PERSISTENT_TTL_EXTEND_TO and bump_persistent_ttl helper pattern already used in backstop_vault. Prioritize timelock given the severity of a silently-expired pending operation. Add a per-crate test confirming TTL is extended after a representative write.

Addressed:

• Changed: timelock/src/lib.rs, governor/src/lib.rs
• Add extend_ttl calls at every persistent write site in timelock/src/lib.rs, governor/src/lib.rs, and treasury_streams/src/lib.rs
• Follow the PERSISTENT_TTL_THRESHOLD/PERSISTENT_TTL_EXTEND_TO convention and bump_persistent_ttl-style helper pattern from backstop_vault
• Prioritize timelock first due to severity of silently-expired pending operations

Changes

• timelock/src/lib.rs (modify)
• governor/src/lib.rs (modify)

Approach

1. Read backstop_vault/src/lib.rs to confirm the PERSISTENT_TTL_THRESHOLD/PERSISTENT_TTL_EXTEND_TO constants and bump_persistent_ttl helper pattern.
2. In timelock/src/lib.rs, add the TTL constants and helper, then call extend_ttl at every persistent write site (pending operation storage) and add a test asserting TTL extension after a representative write.
3. In governor/src/lib.rs, add the TTL constants and helper, call extend_ttl at every persistent write site, and add a TTL-extension test.
4. In treasury_streams/src/lib.rs, add the TTL constants and helper, call extend_ttl at every persistent write site, and add a TTL-extension test.
5. Verify no unrelated crates or logic are modified and archival semantics remain unchanged beyond the added bumps.

Issues

Closes #583

[drips-wave]

@meetestherpeter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits