Repository navigation
zk-proofs: warn that the UltraHonk verifier accepts only non-ZK proofs - #158
Merged
Merged
Conversation
rs-soroban-ultrahonk implements the non-ZK UltraKeccak flavor. Its README says a proof gives no witness-hiding guarantee. The Noir walkthrough used a private age input without that warning. - Mark the Noir row in the toolchain table as non-ZK only. - Add a note to the Noir walkthrough. - Add a pitfall about proofs that do not hide inputs.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add an evaluation assertion covering the verifier’s non-ZK limitation and privacy-sensitive use.
1 open issue
What changed in this PR
Clarifies that the Noir UltraHonk verifier supports non-ZK proofs only and should not be used for privacy-sensitive inputs.
Changes:
- Marks the Noir toolchain as non-ZK only.
- Adds privacy warnings and recommends Groth16 for hidden inputs.
- Documents the witness-hiding limitation.
| File | Summary |
|---|---|
skills/zk-proofs/SKILL.md |
Documents UltraHonk’s non-ZK limitation and privacy implications. |
Review effort: Lite
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Picked this up. Reviewing the claims and Copilot's eval point before I merge. |
evals/README.md asks to update affected scenarios in the same PR when a skill fact changes.
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Verified at 61fe468:
Copilot's Protocol 28 point concerns older text. It is tracked in #159. Merging now. |
Contributor
|
🤖 Automated message from the Stellar Triage Bot. Merged. The skill now warns that the UltraHonk verifier accepts only non-ZK proofs. The Protocol 28 follow-up is #159. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zk-proofsskill sends Noir users tors-soroban-ultrahonkfor on-chain verification. Its Noir example keepsageas a private input. The skill never says that this verifier accepts only non-ZK proofs.The
ultrahonk-soroban-verifierREADME says:ZK verification is still open in rs-soroban-ultrahonk#38. OpenZeppelin's confidential token (v0.8.0) uses this verifier and documents the same limit in its Zero-knowledge setting section.
Changes
The proving commands and the rest of the skill do not change. All new links return HTTP 200.