Repository navigation
SEP-51: Rename Address Types section to Strkey Types - #2047
Open
leighmcculloch wants to merge 2 commits into
Open
leighmcculloch wants to merge 2 commits into
leighmcculloch wants to merge 2 commits into
Conversation
leighmcculloch
enabled auto-merge (squash)
October 26, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the "Address Types" section to "Strkey Types" in SEP-51.
Why
The section was more narrowly named than its contents. It's body contains not just addresses, but also signers and keys. The common feature is that the types discussed are all represented as Strkeys.
This seems like a rather minor change to make, and it is. But nomenclature has an impact, and I noticed that while discussing CAP-72 it is relatively easy to refer to keys and signers as addresses, when they are not. Noticing that I also misused the term in SEP-51 I wish to clean that up.