Repository navigation
Remove allow-list entries for crates no longer in the lockfile - #356
Merged
Merged
Conversation
Removes the 38 entries in `allowed.json` that name crates no longer in `Cargo.lock`, so they can't ship in any build of the bindings on any target. Most predate the move to `bom-tools` (#201); the rest left with older dependency versions. - `third_party` (22): `ansi_term`, `block-modes`, `CoreFoundation-sys`, `crypto-mac`, `futures`, `futures-channel`, `futures-executor`, `futures-io`, `futures-macro`, `IOKit-sys`, `mach`, `matchers`, `memoffset`, `num-integer`, `opaque-debug`, `overload`, `pin-utils`, `ryu`, `sct`, `spin`, `static_assertions`, `winapi` - `build_only` (16): `adler`, `atty`, `errno`, `io-lifetimes`, `is-terminal`, `linux-raw-sys`, `os_str_bytes`, `pathdiff`, `pest`, `proc-macro-error`, `proc-macro-error-attr`, `rustix`, `semver-parser`, `termcolor`, `ucd-trie`, `unicode-segmentation` Checked locally with `bom-tools` 0.3.0 on x86_64 Linux build evidence: the license reports for `rodbus-ffi-c` and `rodbus-ffi-java` are byte-for-byte identical to those from the full list, and both SBOMs generate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 38 entries in
allowed.jsonthat name crates no longer inCargo.lock, so they can't ship in any build of the bindings on any target. Most predate the move tobom-tools(#201); the rest left with older dependency versions.third_party(22):ansi_term,block-modes,CoreFoundation-sys,crypto-mac,futures,futures-channel,futures-executor,futures-io,futures-macro,IOKit-sys,mach,matchers,memoffset,num-integer,opaque-debug,overload,pin-utils,ryu,sct,spin,static_assertions,winapibuild_only(16):adler,atty,errno,io-lifetimes,is-terminal,linux-raw-sys,os_str_bytes,pathdiff,pest,proc-macro-error,proc-macro-error-attr,rustix,semver-parser,termcolor,ucd-trie,unicode-segmentationChecked locally with
bom-tools0.3.0 on x86_64 Linux build evidence: the license reports forrodbus-ffi-candrodbus-ffi-javaare byte-for-byte identical to those from the full list, and both SBOMs generate.