Run fmt, clippy and tests in CI - #79
Merged
Merged
Conversation
Run cargo fmt on collector-utils and router-controller. In pings-collector, drop the signal-handling loop that could only run once (clippy::never_loop, an error) and a redundant closure. Use an array for a router-controller test fixture (clippy::useless_vec). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Check every pull request and push to main with cargo fmt --check, cargo clippy -D warnings and cargo test on the pinned toolchain. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nothing checks formatting, lints or tests before a change is merged. This PR adds a
ciworkflow that runs these checks on every pull request and on every push tomain, and fixes the findings already onmainso the workflow starts green.Changes
Add
.github/workflows/ci.ymlwith three jobs:fmt:cargo fmt --all -- --checkclippy:cargo clippy --workspace --all-targets --locked -- -D warningstest:cargo test --workspace --lockedThe jobs use the toolchain pinned in
rust-toolchain(1.83), installprotobuf-compilerforsqd-messages, and cache builds withSwatinem/rust-cache.Fix what the checks currently report on
main:cargo fmtoncollector-utilsandrouter-controller(formatting only).pings-collector: remove the signal-handlingloop, which could only run once (clippy::never_loop, an error), and a redundant closure. Behaviour is unchanged.router-controller: use an array for a test fixture (clippy::useless_vec).Testing
All three commands pass locally on the pinned toolchain. This PR's own CI run is the first run of the workflow.
🤖 Generated with Claude Code