Build with Rust 1.98 and update dependencies - #81
Merged
Merged
Conversation
Pin 1.98 in rust-toolchain and in the Docker builder images, keeping them on bookworm. Apply the fixes clippy 1.98 asks for: question_mark and unnecessary_map_or in router-controller, useless_borrows_in_formatting in collector-utils and useless_conversion in pings-collector. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cargo update: 258 crates updated, 80 added, 61 removed. The git dependencies (sqd-network, the libp2p fork) keep their pinned revisions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workspace is pinned to Rust 1.83 (November 2024). This PR moves it to 1.98, the current stable release, and updates the dependencies within their semver ranges.
Changes
rust-toolchain:1.83→1.98. CI picks it up from this file.Dockerfile:rust:1.98-bookwormandcargo-chef:latest-rust-1.98-slim-bookworm. Both stay on bookworm, like the current images.router-controller:question_mark,unnecessary_map_orcollector-utils:useless_borrows_in_formattingpings-collector:useless_conversioncargo update: 258 crates updated, 80 added, 61 removed (e.g.tokio1.43 → 1.53,hyper1.5 → 1.11). Thesqd-networkand libp2p fork git dependencies keep their pinned revisions.Not included
Upgrades that need
Cargo.tomland code changes are left for follow-ups:axum0.6 → 0.8,clickhouse0.12 → 0.15,aws-sdk-s3/aws-config0.x → 1.x,prometheus0.13 → 0.14,rand0.8 → 0.10,base64→ 0.23,tikv-jemallocator0.6 → 0.7,test-with0.13 → 0.17.test-with(a dev-dependency ofcollector-utils) depends onproc-macro-error2, which Cargo reports as containing code a future Rust version will reject. This is a warning only.Testing
On 1.98,
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass. Both collectors start and log as before. The Docker images were not built locally.🤖 Generated with Claude Code