chore(codeql): resolve deploy scan findings - #6433
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews completed. Claude reported two findings and Codex reported none. Both Claude findings are confirmed: the stack-trace removal leaves an equivalent exposure in onError, and HTML-entity escaping is visibly lossy inside Markdown code spans and fences.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | apps/cli/src/shared/functions/serve.main.ts:474 |
security |
claude | The stack-trace remediation is incomplete because the same Deno.serve call still includes exception stacks in responses produced by onError. |
| ⚪ NIT | .github/scripts/ai-review/post-review.ts:577 |
ux |
claude | Replacing <!-- with <!-- leaves the entity text visibly rendered when model-authored Markdown quotes the opener inside a code span or fenced block. |
Findings outside the diff
- 🟡 MINOR
apps/cli/src/shared/functions/serve.main.ts:474— The stack-trace remediation is incomplete because the sameDeno.servecall still includes exception stacks in responses produced byonError.
Stats
Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Contributor
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@301a7918fc012620b040b9a1c532bfbb012ab5d6Preview package for commit |
Coly010
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
fixes the CodeQL check blocking prod deploy & turning merges red
which was caused by two new alerts on develop, and is now fixed by escaping HTML comment openers in the AI review sanitizer instead of stripping comments (stripping was not a fixpoint, so
<!<!---->--re-formed an opener) andby dropping the
tracefield from the fallback 500 response in the functions serve template.The stack is still printed to the terminal by the existing
console.error....ref: