Skip to content

chore(codeql): resolve deploy scan findings - #6433

Merged
Coly010 merged 2 commits into
developfrom
7ttp/codeql-unblock-deploy-6416
Sep 2, 2026
Merged

chore(codeql): resolve deploy scan findings#6433
Coly010 merged 2 commits into
developfrom
7ttp/codeql-unblock-deploy-6416

Conversation

@7ttp

@7ttp 7ttp commented Sep 2, 2026

Copy link
Copy Markdown
Member

TL;DR

fixes the CodeQL check blocking prod deploy & turning merges red
which was caused by two new alerts on develop, and is now fixed by escaping HTML comment openers in the AI review sanitizer instead of stripping comments (stripping was not a fixpoint, so <!<!---->-- re-formed an opener) and

by dropping the trace field from the fallback 500 response in the functions serve template.
The stack is still printed to the terminal by the existing console.error....

ref:

@7ttp 7ttp self-assigned this Sep 2, 2026
@7ttp
7ttp requested a review from a team as a code owner September 2, 2026 08:40

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI Review

Both independent reviews completed. Claude reported two findings and Codex reported none. Both Claude findings are confirmed: the stack-trace removal leaves an equivalent exposure in onError, and HTML-entity escaping is visibly lossy inside Markdown code spans and fences.

Findings

Severity Location Category Sources Claim
🟡 MINOR apps/cli/src/shared/functions/serve.main.ts:474 security claude The stack-trace remediation is incomplete because the same Deno.serve call still includes exception stacks in responses produced by onError.
⚪ NIT .github/scripts/ai-review/post-review.ts:577 ux claude Replacing <!-- with &lt;!-- leaves the entity text visibly rendered when model-authored Markdown quotes the opener inside a code span or fenced block.

Findings outside the diff

  • 🟡 MINOR apps/cli/src/shared/functions/serve.main.ts:474 — The stack-trace remediation is incomplete because the same Deno.serve call still includes exception stacks in responses produced by onError.

Stats

Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0


Models: claude-opus-5 + gpt-5.6-sol · Trigger: auto · Workflow run

This review runs once per PR. A maintainer can request another with a /ai-review comment.

Comment thread .github/scripts/ai-review/post-review.ts Outdated
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Supabase CLI preview

npx --yes https://pkg.pr.new/supabase/cli/supabase@301a7918fc012620b040b9a1c532bfbb012ab5d6

Preview package for commit 301a791.

@Coly010
Coly010 added this pull request to the merge queue Sep 2, 2026
Merged via the queue into develop with commit 4fe9c9d Sep 2, 2026
35 checks passed
@Coly010
Coly010 deleted the 7ttp/codeql-unblock-deploy-6416 branch September 2, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants