Performance optimisations (filesystem) - #36
Open
synesissoftware wants to merge 11 commits into
Open
synesissoftware wants to merge 11 commits into
synesissoftware wants to merge 11 commits into
Conversation
Define CSTRING_ASSERT once in src/internal.h, with <assert.h>, and drop the copies in cstring.core.c and cstring.vector.c. Vector call sites use that macro in place of CSTRING_VECTOR_ASSERT. dllmain.c includes internal.h.
Add cstring_try_get_regular_file_size_m_() as POSIX stat in fs.c and Win32 GetFileAttributesExA in fs.win.c. Declare it, plus the 64-bit integer typedefs, in internal.h, and pick the source from src/CMakeLists.txt.
Keep fs.c common, build fs.unix.c on UNIX and fs.win.c/win.c on Win32, and stop compiling the POSIX stat path into the Windows core.
Add cstring_try_get_stream_size_m_() with portable 64-bit/long seek/tell selection, always restore the prior stream offset, and declare it in internal.h.
mwsis
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.