fix: cstring_readline() - #37
Merged
Merged
Conversation
Example, performance, and scratch runners do not take --verbosity and do not pass it to the programs they launch. Each program is invoked with no extra arguments. Unit and component runners still accept the flag and forward it. Apply the same change to the cstring runners and to the cmake-helpers templates they are copied from.
Count every character read from the stream in numRead, including the terminating newline. A CRLF's CR is still counted and still stripped from the string. Previously that newline was omitted, so a line containing only LF reported zero. Add single-line LF and CRLF component cases and align the existing numRead expectations. Record the correction as 4.0.19.
Count every character read for the line in numRead, including the terminator, and do not store CR or LF. A lone CR, including CR at end of stream, ends the line with CSTRING_RC_SUCCESS and pushes the following character back. Add single-line LF, CRLF, and CR component cases. An embedded CR now splits a cstring_vector_readLines line. Record the correction as 4.0.19.
mwsis
approved these changes
Oct 2, 2026
xtests::temp_file creates its Windows file with an exclusive handle and leaves that handle open. The readline component tests then fopen the same path, which Windows rejects as a sharing violation. Pass CloseOnOpen so the creating handle is closed before fopen. Drop the local argc == 0 guard, which skipped the suite on every normal invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.