Conversation
|
ovitrif
force-pushed
the
fix/disable-all-toasts
branch
from
September 29, 2026 14:05
627c714 to
50c7355
Compare
1 task
jvsena42
reviewed
Sep 29, 2026
jvsena42
left a comment
Member
There was a problem hiding this comment.
No findings. The visible-toast-on-enable case is accepted as out of scope in the description.
Checked and clean:
- The toggle only appears in Dev Settings, via
@AppStorage, off by default.areToastsDisabledfalls back toEnv.isDebuglike the othershowDevSettingsreaders. - The guard at the top of
AppViewModel.toast(type:…)is the only path toToastWindowManager.showToast, and haptics are suppressed too. SupportScreenflipsshowDevSettingsbefore toasting, so there is no flash on dev-mode changes.AppResetclears the key.ToastSuppressionTestscovers the three predicate states.
Parity with synonymdev/bitkit-android#1371: same semantics and tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #828
Twin: synonymdev/bitkit-android#1371
This PR adds a Dev Settings toggle that hides all toasts, for testing and demo recordings.
Description
Out of Scope
Design
N/A — no design available.
Preview
QA Notes
Journeys
temporary
disable-all-toasts.xml— toasts stay hidden while dev mode and the toggle are on, and return once dev mode is offdisable-all-toasts.xml
Manual Tests
N/A
Automated Checks
ToastSuppressionTests.swift— toasts are hidden only while dev mode and the toggle are both on