Conversation
Swipe to pay on the send confirmation stays disabled and shows its loading state while an on-chain payment has no fee rate yet. submitPayment also resolves a missing fee rate before anything is consumed, so an automatic payment never starts without one.
|
Pushed 9be9583: renamed the changelog fragment to this PR's number, as |
…o fix/swipe-waits-for-fee-rate # Conflicts: # Bitkit/Views/Wallets/Send/SendConfirmationView.swift
|
Pushed e3a17f3: merged master (it had #830 and #831 in |
…o fix/swipe-waits-for-fee-rate # Conflicts: # Bitkit/Views/Wallets/Send/SendConfirmationView.swift
|
Pushed dc31e10: merged master, which now has #826. Both sides' helpers in |
Closes #775
This PR keeps Swipe To Pay disabled until the fee rate has loaded.
Description
Out of Scope
Bitkit/Views/Wallets/Send/SendSheet.swift: the fee-rate fetch itself (its timeout, error logging and when it runs) is unchanged; if the fetch fails for good the swipe stays disabled until the funding source is switched or the sheet is reopened.Design
N/A — no design available. The swipe reuses its existing disabled and loading states.
Preview
QA Notes
Journeys
N/A — not drivable; see Manual Tests.
Manual Tests
regression:Lightning invoice → Send confirmation → the swipe is enabled immediately, without waiting for the fee rate — network throttling not in CapabilitiesAutomated Checks
SendConfirmationSwipeTests.swift— on-chain payment without a fee rate disables the swipe, and it enables once a rate is setSendConfirmationSwipeTests.swift— Lightning and hardware payments never wait on the wallet fee rate