Conversation
…alue A node that cannot announce channels only accepts unannounced ones, so LDK's default of 10% of the channel value as maximum inbound HTLC value in flight capped every single incoming payment far below the inbound capacity. Set it to 100% for such nodes, as already done for unannounced channels we open ourselves. The integration test opens a channel to a node without a node alias and pays it 9% and 20% of the channel value; the second payment fails without the change.
|
Pushed 555d5db: dropped the changelog entry from this PR; the release PR adds it in the fork's single section. Dispatched the Rust CI on this branch: https://github.com/synonymdev/ldk-node/actions/runs/36661558748 |
|
The Rust CI run on this branch (https://github.com/synonymdev/ldk-node/actions/runs/36661558748) failed in "build (ubuntu-latest, stable)", and fail-fast cancelled the other jobs. The failure is on |
Refs:
Description
inbound_htlc_in_flight_limit_for_unannounced_node: opens a 1,000,000 sat channel to a node without an alias, pays it 9% (works with and without the change) and 20% of the channel value (fails withPaymentSendingFailedwithout the change).2867d5c1a, in the 0.3 pre-releases); the fork is on LDK 0.2.0, where it is still 10%.Out of Scope
src/builder.rs,src/event.rs: the LSPS2 paths keep their own 100% override.unannounced_channel_max_inbound_htlc_value_in_flight_percentage); when the fork moves to an LDK release with that option, this override can be removed.QA Notes
Automated Checks
inbound_htlc_in_flight_limit_for_unannounced_nodeintests/integration_tests_rust.rs: failed onmain(a payment above 10% of the channel value must be routable: PaymentSendingFailed), passes with the change.lsps2_client_service_integration,lsps2_client_trusts_lsp,lsps2_lsp_trusts_client_but_client_does_not_claim,multi_hop_sending: pass.channel_full_cycle_electrumdid not finish locally: it stops at the splice step onmainas well as with the change. CI here is manual (rust.ymlruns onworkflow_dispatch); I dispatched it on this branch (https://github.com/synonymdev/ldk-node/actions/runs/36661558748): the ubuntu stable build fails on warnings thatmainhas too, and fail-fast cancelled the rest, so the full suite has not run yet. It is the readiness gate oncemainbuilds on stable.Manual Tests
master(2.5.0) on a regtest LND channel of 1,000,000 sats, with alibldk_nodebuilt from 0.7.0-rc.66 plus this one-line change swapped in: the channel is accepted withmax_htlc_value_in_flight_msat: 1000000000(was100000000), and single payments of 110,000 sats (11%) and 500,000 sats (50%) succeed with "Received Instant Bitcoin". Without the change the 11% payment fails.