Repository navigation
Fix demo-mode auto-index after the embedding change - #161
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#159 made
rag.init_collection'svector_sizeargument required, so a collection is never initialised at a dimension the embedding model does not produce._ensure_demo_indexedinsrc/ragbot.pystill calledinit_collection(DEMO_WORKSPACE_NAME)without it, so the firstRAGBOT_DEMO=1run would raiseTypeErrorbefore indexing anything. No test covered the hook.The call is removed:
index_contentandindex_skillseach initialise the workspace at the model's dimension themselves.tests/test_demo_mode.pynow covers the hook. One test checks that it indexes the bundled content and demo skills into their workspaces when the index is empty; the other checks that it skips them when the index is populated. Onmainthe first test fails with theTypeError; with this change both pass.make test-fast: all green.🤖 Generated with Claude Code