Repository navigation
ci: route ordinary jobs to self-hosted pools - #63
Conversation
Keep hosted npm publication behind a self-hosted registry preflight and preserve release provenance and retry behavior.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tangletools
left a comment
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 4f58f103
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-23T02:41:35Z
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f58f10311
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| verify: | ||
| name: verify (Node ${{ matrix.node-version }}) | ||
| runs-on: ubuntu-latest | ||
| runs-on: [self-hosted, Linux, X64, ci-public] |
There was a problem hiding this comment.
Because this public repository still triggers the workflow on pull_request, this change sends fork-controlled code through checkout, dependency installation, tests, and builds on ci-public. A contributor can therefore execute arbitrary code on the self-hosted machine and potentially persist into later trusted jobs or access its network; GitHub explicitly warns against this configuration. Keep pull-request verification on a hosted runner, or use a demonstrably disposable and network-isolated runner rather than a persistent self-hosted host.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The public verification job was also inheriting this repository’s default write token. Draft #64 explicitly limits it to contents:read and disables checkout credential persistence; it is held for required qualification. Publication remains in the existing hosted job, and the public registry check is read-only. The existing public CI pool is persistent, so this does not claim disposable execution or eliminate public-job co-tenancy; that material limit remains with the infrastructure owner under the accepted public-read-only versus isolated trusted-producer policy.
Ordinary workflow jobs now use the existing self-hosted pool; hosted npm trusted publishing remains behind a self-hosted registry preflight.
Baseline: GitHub billing usage API reports 14.0 hosted minutes for this repository from October15 through the retained October23 baseline read (last UTC date partial). Net Actions usage in that window was $0.0. After-billing totals remain pending the maintained daily usage report; no absent day is inferred as zero.
Validation: independent parent routing review and changed-workflow actionlint passed. Native hooks passed. Beelink qualification passed on this exact head; the native hooks and changed-workflow actionlint passed. No new tests, CI gates, dispatches or production-secret access added.