Skip to content

fix(packaging): share the consuming application Hono peer - #65

Merged
drewstone merged 1 commit into
mainfrom
fix/hono-peer-10458
Oct 23, 2026
Merged

drewstone merged 1 commit into
mainfrom
fix/hono-peer-10458

Conversation

@drewstone

@drewstone drewstone commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

An application mounting the gateway can get two Hono installations: its own router and the gateway's regular dependency. In the retained Underwriting typecheck, Hono 4.13.8 and the gateway's nested 4.13.13 disagree on the private GET_MATCH_RESULT identity at both gateway mounts.

This prepares patch version 0.11.5 with Hono as a required peer and development dependency, preserving the existing compatible range and all security overrides. The lockfile moves Hono's root importer entry to development dependencies. Install guidance identifies the application's Hono installation as the shared owner.

Owner: op-company:pr-closer.

The integrating owner completed the final source, native proof and full PR review in the final review comment. The normal required approval and auto-merge completed at commit 2b21e122ae520725c119cf3fce362163a9b350e4, whose merged tree matches the reviewed reconciliation. The normal v0.11.5 tag started publisher run 39919133209, attempt 1, on that exact commit. Native qualification passed as recorded below; registry publication and published-consumer acceptance remain pending. No served outcome is claimed.

Before merge, all of these conditions must be shown true:

  • The committed three-file change matches the independently reviewed source, current main is reconciled, and all applicable PR reviews and comments are answered.
  • The normal managed frozen install validates the lockfile; package typecheck, the reviewed existing gateway integrations, build and pack pass on the exact final source.
  • Packed metadata declares Hono as a peer and leaves the runtime import external. A real package-manager resolution using an existing no-direct-Hono consumer policy succeeds without adding Hono to that consumer's manifest.
  • The exact retained Underwriting source and diagnostic lock reproduce the two Hono identity errors. Installing only the packed candidate into an isolated fixture preserves the application's Hono 4.13.8 and other diagnostic versions, resolves both mounts to the same Hono instance, and makes its full typecheck green. The actual diagnostic used Sandbox 0.64.21; the original failed adoption used 0.64.20.
  • The integrating owner reads the complete final PR and confirms the conditions above. No merge or tag precedes that check.

Native qualification passed on commit 5965f34e9fc436b8a044f11781d74c6da49ef1a2 through normal managed gate beelink1-4cf5dbeff6b63886669aa3ee831c4261, actual process exit 0. Frozen install, package typecheck, 31 checks across the three reviewed integration files, build and pack passed. Packed metadata keeps Hono external as a peer; the existing no-direct-Hono policy resolved the peer normally. The immutable retained Underwriting source reproduced exactly the two baseline Hono errors, then its full typecheck passed with only the packed gateway substituted. Both packages resolved the same Hono 4.13.8 installation, and all other diagnostic versions were preserved. Logs, package and identity evidence are retained outside the cache and copied off the host. The earlier gate stopped before package checks when the disposable consumer cache was absent; the reviewed, SHA-256-checked tracked-source archive removed that harness dependency. This proves the scoped package and compile conditions, without a full-suite or served claim.

After merge, delivery remains incomplete until the normal version tag drives the existing trusted npm publisher, the registry archive and provenance match the intended release, and the published package's Underwriting type proof is retained. Refresh the registry before tagging to avoid reusing an already published version. Publication is delivery acceptance after merge, not a prerequisite that requires publication before merge.

The consumer worktree, application pins, security overrides, casts and mount APIs are unchanged. The prior ci-zero branch is retained separately; its workflow permissions PR #64 has merged into main. The integrating owner verified that the prospective merge preserves all qualified package and consumer inputs.

Run ID: run_339f72fffac7e5cbbc20200aefb9e31b

@drewstone

drewstone commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Owner: op-company:pr-closer.
Disposition: merged and published; this PR's package-delivery acceptance is complete.

Normal v0.11.5 publisher39919133209 attempt1 succeeded on merge2b21e122; both Node versions passed532tests/31files. Registry archive/SHA512/shasum/gitHead and provenance source/digest identities match the intended release. All96 non-manifest files match the qualified pack, and the published manifest matches the reviewed source. Cryptographic signature verification was not performed.

Actual managed consumer gate beelink1-dc60a97866f9fffd67af77fcf232098f exited0. The exact retained Underwriting source and diagnostic graph passed its full typecheck with only registry Gateway0.11.5 substituted, its archive integrity pinned to the verified publication, and the same Hono4.13.8 instance preserved. Full native evidence is retained off-host.

The application's current dependency-plan caller proof separately passed19focused checks, including native HTTP gzip/authentication, real case read, persisted run and output-cap enforcement. The newer plan uses agent-app0.63.1; full application qualification, automatic adoption, normal release and served proof remain separate task10458 acceptance. No application served result is claimed.

@drewstone

Copy link
Copy Markdown
Contributor Author

Final integrating review completed on head 5965f34. I read the complete body, three-file diff, comment, reviews and inline findings; no unanswered finding remains.

Normal gate beelink1-4cf5dbeff6b63886669aa3ee831c4261 exited 0: frozen install, types, 31 integration checks, build/pack, external Hono peer, no-direct-Hono package-manager resolution, exact two-error consumer baseline and packed-candidate full typecheck passed. The candidate changes only Gateway in the isolated consumer manifest and preserves the shared Hono 4.13.8 instance and other diagnostic package versions. The retained package's 58 source/README blobs match the reviewed commit; full proof copied off-host with archive SHA256 567b0838cf5386e5e85d51dd275a2f1c2cf87c96575ad75b97cf2fc4b00d3c45.

Current main 7af7c3e is reconciled by a conflict-free prospective merge tree 20ae550c86a856ed8e56a5cdec0d9b494f026e5c. Only the independently reviewed publisher read-only permission/checkout credential settings differ from the qualified source; all package and executable check inputs are byte-identical. PR64 has independently merged; its branch was preserved.

All pre-merge conditions are satisfied. Normal version-tag publication, registry identity/provenance and the published consumer compile remain delivery acceptance after merge. No served outcome is claimed.

@drewstone
drewstone marked this pull request as ready for review October 23, 2026 07:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T07:36:18.774446Z 5965f34 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tangletools tangletools left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 5965f34e

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-23T07:35:35Z

@drewstone
drewstone merged commit 2b21e12 into main Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants