Skip to content

fix: build on @tangle-network/ui 11.42.0, DiffView on @pierre/diffs 1.6, files pane keeps scroll on load - #447

Merged
drewstone merged 9 commits into
mainfrom
fix/ui-11-42
Oct 25, 2026
Merged

drewstone merged 9 commits into
mainfrom
fix/ui-11-42

Conversation

@drewstone

@drewstone drewstone commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem. Three production consumer bugs in one shared dependency, folded into one patch release (root consolidation 2026-10-25 00:14Z; agent-record closes #444 as folded):

  • main's Storybook and package builds fail with MISSING_EXPORT: src/primitives/index.ts re-exports HoverCard*, Breadcrumb and other primitives that @tangle-network/ui 11.40.x does not export (run 40143007375).
  • DiffView draws nothing on @pierre/diffs 1.6 (third FileDiff argument became requestOwnerRender; "e is not a function", 0 px pane). From fix(workbench): DiffView renders on @pierre/diffs 1.6 #444 (7bf2490), authored by agent-record.
  • WorkspaceFilesPane focuses Back when it mounts with a preview open, scrolling a phone page past the run header.

Change.

  • @tangle-network/ui 11.42.0 for dependency, dev and peer (published; its dist/primitives exports the names main re-exports), relocked.
  • DiffView omits the third FileDiff argument (renders on 1.5 and 1.6).
  • WorkspaceFilesPane moves focus only when the reader opens or closes a preview, with preventScroll.
  • Radix packages moved to one copy each (@radix-ui/react-dialog ^1.3.1, react-dropdown-menu ^2.2.1, react-select ^2.4.1): ui 11.42.0's hover-card brought a second set of Radix internals, which the radix-single-copy test refuses (1b7eb78).
  • @tangle-network/brand 1.26.2 (dev) and ^1.26.2 (peer): ui 11.42.0 peers brand ^1.26.2, and the packed consumer install failed ERESOLVE without it (9187874).
  • main (421586a, which landed the ui bump, the DiffView fix and the focus fix through fix(workbench): DiffView renders on @pierre/diffs 1.6 #444) merged in (06d0600); this PR's remaining delta is the re-exports, Radix and brand.
  • Patch changesets.

Why long-term right. Fixes each cause in its owner and ships one release for every consumer, instead of two queued SDK fixes or a consumer workaround.

Evidence. Stages at head 9187874 on beelink2: typecheck, build, 1,427/1,427 tests, package smoke (26 JS + 3 CSS exports, with and without optional peers), bridge 100/100. The merge gate is beelink-gate --urgent --merge 447 running the full pnpm signoff (including all 1,475 visual snapshots); it merges only if every stage is green, and its receipt is posted here. Acceptance: agent-record's phone-landing smoke and DiffView render on the published artifact.

Cost. Patch release; rollback is the previous patch.

Supersedes #444 (folded) and the #443 source checkpoint.

Run ID: run_369e8dcc6188e337ad6eda9097f3a5e9

tangletools
tangletools previously approved these changes Oct 25, 2026

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 3602874f

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T00:18:57Z

…series primitives from ./primitives and the root
tangletools
tangletools previously approved these changes Oct 25, 2026

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — ee797e0c

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T00:46:59Z

tangletools
tangletools previously approved these changes Oct 25, 2026

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 06d0600d

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T01:12:08Z

@drewstone

Copy link
Copy Markdown
Contributor Author

Independent source review at ee797e0c3997739d93f82e0e8f470d47239c586a: APPROVE_SOURCE_ONLY, zero new must-fix findings. Reviewed the complete delta from the previously reviewed 3602874f: the two export surfaces now expose the matching UI primitive contract. Prior DiffView, focus and dependency review is reused.

This is source approval only. Native qualification, publication, consumer adoption and the served phone-landing/nonzero-diff journey remain required. Preserve actual qualification failures and fix forward in their owner; no additional root review hold is introduced.

tangletools
tangletools previously approved these changes Oct 25, 2026

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 9187874e

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T01:35:58Z

@drewstone

drewstone commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

Delta since the source review at ee797e0: 1b7eb78 moves @radix-ui/react-dialog, react-dropdown-menu and react-select to the cohort that ui 11.42.0's hover-card uses, so each Radix package has one copy (radix-single-copy test); 06d0600 merges main 421586a (#444 already carried the ui 11.42.0 bump, the DiffView fix and the focus fix; conflicts resolved keeping this branch's package.json and lockfile); 9187874 bumps @tangle-network/brand to 1.26.2 (dev) and ^1.26.2 (peer) because ui 11.42.0 peers brand ^1.26.2 and the packed consumer install failed ERESOLVE. git diff ee797e0c 9187874 outside the lockfile touches only package.json and .changeset/brand-1-26-2.md. Reviews read: tangletools blanket auto-approvals (not code review) and the root source approval above.

CatalogLight/Dark, DetailLight/Dark and DiffView DarkTheme/LightTheme set globals.sandboxTheme, which outranks
the URL global, so their opposite-theme runs failed the page-theme assertion on main as well.
tangletools
tangletools previously approved these changes Oct 25, 2026

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — ca4d29e5

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T06:24:57Z

… stories

Full run at ca4d29e on beelink2 with --update-snapshots=changed: 51 changed (ui 11.42.0 primitives: status-chip
glyph, IntegrationsPanel collapses behind Show all 28, input and button borders) and 8 missing (AgentProfilePicker
host-editor and save-recovery). Samples compared against main's baselines before committing.

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 5729b357

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T07:26:40Z

@drewstone

Copy link
Copy Markdown
Contributor Author

Visual suite repair since the last comment (main's test:visual has been red since #444; a same-host run on main 421586a fails 69 of the same tests, and this PR added none):

  • ca4d29e: stories that pin globals.sandboxTheme (CatalogLight/Dark, DetailLight/Dark, DiffView DarkTheme/LightTheme) are captured only in their own theme; the URL global cannot override a story global, so their opposite-theme runs failed the page-theme assertion.
  • 5729b35: 51 baselines regenerated for ui 11.42.0's intended primitive changes (status-chip glyph, IntegrationsPanel collapses behind "Show all 28", input and button borders; samples compared against main's) and 8 missing baselines for the AgentProfilePicker host-editor and save-recovery stories. Full run at ca4d29e (beelink2): 1,456 passed, 4 flaky, 1 failed (embeddedappview networkidle timeout under load).
    The final --urgent --merge 447 signoff runs with BEELINK_GATE_MAX_HOLD=150m because the full suite outlasts the default 45-min hold at current host load.

@drewstone

Copy link
Copy Markdown
Contributor Author

Collapse lane: this PR's owner run has exited, so I am gating it on beelink2 (--merge 447, typecheck/build/test/test:package/test:bridge at 5729b35) and merging on exit 0. #448 then replaces the two hand-typed primitive lists with export * and releases both as 0.137.0.

@drewstone
drewstone merged commit 1419d6b into main Oct 25, 2026
@drewstone

Copy link
Copy Markdown
Contributor Author

Gated and merged by the collapse lane (owner run exited): beelink2 gate beelink2-f4f6f2ceb0cd7acca655c805c7b9a0e3 exit 0 on 5729b35, pnpm typecheck && pnpm build && pnpm test && pnpm test:package && pnpm test:bridge. The visual suite was not part of this gate (main's test:visual has been red since #444). #448 releases this as 0.137.0.

drewstone added a commit that referenced this pull request Oct 25, 2026
…rt *, deprecate the subpath (#448)

refactor(primitives): forward @tangle-network/ui/primitives with export *, deprecate the subpath

**Problem.** `src/primitives/index.ts` and `src/index.ts` each re-export about 240 `@tangle-network/ui/primitives` names through hand-typed lists. They are copies of ui's own export list (dotfiles census xrepo rank 3, brand~sandbox-ui), and they drift on every ui release: MISSING_EXPORT on ui 11.40, and the names ui 11.42.0 added (MetricChart, series helpers; HoverCard/Breadcrumb at root) are absent until someone types them in (#447 adds 48 lines for that).

Run ID: run_9600d4f3ec2a3cd6b350309083c935e5
drewstone added a commit that referenced this pull request Oct 25, 2026
…declares (#449)

fix(release): Auto Release fails at startup; give the prepare call the ceiling its called file declares

**Problem.** Every Auto Release & Publish run since c16c5f9 (10-23) ends in `startup_failure` (runs on 1419d6b, edd99e4, 421586a). `package.json` on main says 0.137.0; npm latest is 0.136.1, so #447 and #448 never shipped.

Run ID: run_369e8dcc6188e337ad6eda9097f3a5e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants