Skip to content

fix(workspace): Back takes focus only when the reader opened the file (0.137.1) - #451

Merged
drewstone merged 1 commit into
mainfrom
fix/files-pane-landing-focus
Oct 25, 2026
Merged

drewstone merged 1 commit into
mainfrom
fix/files-pane-landing-focus

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Problem. On a fresh load of a run page that mounts WorkspaceFilesPane and then loads its selectedPath (agent-record 0.83.0, /run/test-disposable-smoke-20261022a at 390x844 and 1512x945), focus jumps to 'Back to files' with no user action. 0.137.0's guard only covered a preview present at mount. root's acceptance wants no autofocus on landing.

Change. Back takes focus only after the reader opens a file from the tree in this pane; any other arrival of a preview leaves focus and scroll alone. Also: DiffView drops its helper line beside Wrap lines (the toggle's pressed state carries the mode) and the mock readability test that asserted it.

Release. 0.137.1 (package.json bump triggers Auto Release, fixed by #449). agent-record adopts it in 0.87.0.

Run ID: run_369e8dcc6188e337ad6eda9097f3a5e9

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — de3b9519

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T23:30:53Z

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T23:32:07.209728Z de3b951 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@drewstone
drewstone merged commit b83af03 into main Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants