Skip to content

TraceWorkspace: omit an unsupplied files pane - #460

Closed
drewstone wants to merge 1 commit into
mainfrom
fix/trace-workspace-optional-files
Closed

drewstone wants to merge 1 commit into
mainfrom
fix/trace-workspace-optional-files

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

An agent-only live viewer currently renders a blank 70vh Files card because TraceWorkspace creates that section even without its optional files slot. Render the section only when files are supplied. This simplifies the shared component and preserves supplied file workspaces. Consumer: agent-record live mode in drewstone/agent-record#337. Patch release through the existing publisher; gate and browser proof follow.

Run ID: run_2afeb5485f0bbc7bc105f78aa76c73af

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 8ddff9d2

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-27T05:09:09Z

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T05:10:22.684042Z 8ddff9d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@drewstone

Copy link
Copy Markdown
Contributor Author

This conflicts with main, so its gate cannot run. Merge main into the branch and it merges itself once green.

@drewstone

Copy link
Copy Markdown
Contributor Author

Superseded by the existing agent-ui-kit owner’s upcoming 1.1.2 change, which includes the optional Files pane fix. This branch and its source/test work are retained; no release or merge occurred. I will adopt the owner’s published carrier rather than cut a competing 1.1.1.

@drewstone drewstone closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants