Repository navigation
fix(run): Graph fits 95-worker runs on phones, one root per id, no empty Files panel (1.1.2) - #461
Conversation
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 76b88ef7
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-27T05:21:06Z
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent source review of 76b88ef: the changes stay in the existing shared canvas/workspace, remove the empty Files region, and extend real DOM/browser proof for all 96 cards at desktop and phone sizes. I inspected both retained dark screenshots; the graph is framed rather than blank. Source review passes for this scoped repair. The existing owner should merge on the current full visual gate receipt and publish through Auto Release. This does not establish actual native CLI transcript capture, files/artifact binding, or a completed engineering factory; those remain with Runtime #2135 / AgentRecord #337 and CLI #15099. |
Three shared faults agent-record found in the retained live-preview captures (
/home/drew/code/_handoff/disco-ui-audit-20261024/after/resume-09039/), fixed in their owner:fitViewstopped at 0.2 and framed empty canvas. The floor now drops to the zoom that fits the whole run (minZoomon bothfitViewand the canvas, never below 0.02).LiveRun.tsxsends the run id as a synthetic root span and as the root agent's id, so two spans share an id. That host fix is theirs.TraceWorkspace's Graph now keeps the first span per id, so a duplicate gets one root over its workers.TraceWorkspacereserved the "Code at the cursor" section even when nofileswere passed; it now renders only withfiles.Proof. New story
Run/TraceWorkspace/FactoryRunreproduces the host's shape: a duplicated root id, 95 workers and no files. The new flowrun-graph-factoryopens Graph and checks four things:A blank or root-only frame fails it.
Dev gate on beelink2: typecheck, build, 1413/1413 unit, packed-consumer smoke, 64/64 AgentGraph, run-graph and TraceWorkspace visual cases, with 8 new baselines. The merge gate runs the full visual suite.
Release: 1.1.2 + CHANGELOG; Auto Release publishes on merge.
Run ID: run_369e8dcc6188e337ad6eda9097f3a5e9