Skip to content

fix(run): Graph fits 95-worker runs on phones, one root per id, no empty Files panel (1.1.2) - #461

Merged
drewstone merged 3 commits into
mainfrom
fix/graph-fit-and-empty-files
Oct 27, 2026
Merged

drewstone merged 3 commits into
mainfrom
fix/graph-fit-and-empty-files

Conversation

@drewstone

Copy link
Copy Markdown
Contributor

Three shared faults agent-record found in the retained live-preview captures (/home/drew/code/_handoff/disco-ui-audit-20261024/after/resume-09039/), fixed in their owner:

  1. Graph blank at 390 with 95 workers. The 0.2 zoom floor sat above the zoom that fits the run, so fitView stopped at 0.2 and framed empty canvas. The floor now drops to the zoom that fits the whole run (minZoom on both fitView and the canvas, never below 0.02).
  2. Root drawn inside its own team, children below the frame. agent-record traced it to its draft Show live Runtime graphs through the shared TraceWorkspace drewstone/agent-record#337: LiveRun.tsx sends the run id as a synthetic root span and as the root agent's id, so two spans share an id. That host fix is theirs. TraceWorkspace's Graph now keeps the first span per id, so a duplicate gets one root over its workers.
  3. Empty 70vh Files panel. TraceWorkspace reserved the "Code at the cursor" section even when no files were passed; it now renders only with files.

Proof. New story Run/TraceWorkspace/FactoryRun reproduces the host's shape: a duplicated root id, 95 workers and no files. The new flow run-graph-factory opens Graph and checks four things:

  • 96 agent cards are drawn, counting both card types;
  • every card's box is inside the canvas, at desktop and phone, in both themes;
  • the root card sits above its team's frame;
  • no "Code at the cursor" region exists.

A blank or root-only frame fails it.

Dev gate on beelink2: typecheck, build, 1413/1413 unit, packed-consumer smoke, 64/64 AgentGraph, run-graph and TraceWorkspace visual cases, with 8 new baselines. The merge gate runs the full visual suite.

Release: 1.1.2 + CHANGELOG; Auto Release publishes on merge.

Run ID: run_369e8dcc6188e337ad6eda9097f3a5e9

@tangletools tangletools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved PR — 76b88ef7

Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.

tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-27T05:21:06Z

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T05:22:19.434241Z 76b88ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@drewstone

Copy link
Copy Markdown
Contributor Author

Independent source review of 76b88ef: the changes stay in the existing shared canvas/workspace, remove the empty Files region, and extend real DOM/browser proof for all 96 cards at desktop and phone sizes. I inspected both retained dark screenshots; the graph is framed rather than blank. Source review passes for this scoped repair. The existing owner should merge on the current full visual gate receipt and publish through Auto Release. This does not establish actual native CLI transcript capture, files/artifact binding, or a completed engineering factory; those remain with Runtime #2135 / AgentRecord #337 and CLI #15099.

@drewstone
drewstone merged commit b3d45d8 into main Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants