soundwire: cadence_master: wait and cancel cdns->work before clock stop - #5863
Merged
bardliao merged 1 commit intoAug 31, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent peripheral-event handling from racing with the SoundWire Cadence master clock-stop sequence, which can otherwise lead to IO transfer timeouts during suspend/clock stop.
Changes:
- Adds a workqueue cancellation/wait step before stopping the bus clock in
sdw_cdns_clock_stop().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1715
to
+1719
| /* | ||
| * wait for any in-flight peripheral event handling to complete before | ||
| * stopping the clock | ||
| */ | ||
| cancel_work_sync(&cdns->work); |
bardliao
force-pushed
the
cancel-work-before-clock-stop
branch
from
July 31, 2026 08:49
800a81e to
32da271
Compare
A peripheral event could happen druing the clock stop process. We need to wait for the event be handled before stoping the bus clock. Otherwise, we will get the IO transfer timed out issue. Fixes: af4cc91 ("soundwire: cadence: mask Slave interrupt before stopping clock") Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
cancel-work-before-clock-stop
branch
from
August 31, 2026 05:10
32da271 to
36fde41
Compare
davidlin923
approved these changes
Aug 31, 2026
davidlin923
left a comment
davidlin923
left a comment
There was a problem hiding this comment.
After undergoing 20,000 stress tests on several machines, the function remained normal.
shumingfan
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A peripheral event could happen druing the clock stup process. We need to wait for the event be handled before stoping the bus clock. Otherwise, we will get the IO transfer timed out issue.
Fixes: af4cc91 ("soundwire: cadence: mask Slave interrupt before stopping clock")