topology2: tplg-targets-ace3.cmake: Correct the platform for WCL dmic… - #11161
topology2: tplg-targets-ace3.cmake: Correct the platform for WCL dmic…#11161ujfalusi wants to merge 1 commit into
Conversation
… fragments There is no platform as wcl defined since it is identical to PTL. For the DMIC blob creation a correct platform is needed and in case of PLATFORM=wcl, this is not going to happen. Use the correct PLATFORM=wcl to build working DMIC blobs. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward correction to platform key usage with low risk, with only a minor PR-description/comment clarity nit noted.
Pull request overview
This PR adjusts topology2 build target definitions so the WCL DMIC topologies use the PTL platform key, aligning with the existing platform override set (PTL exists; WCL does not appear to have its own platform override file).
Changes:
- Update all
sof-wcl-dmic-*topology target tuples to usePLATFORM=ptlinstead ofPLATFORM=wcl.
File summaries
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace3.cmake | Switch WCL DMIC target tuples to PLATFORM=ptl to match available platform overrides and enable correct DMIC blob preprocessing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -304,42 +304,42 @@ NHLT_BIN=nhlt-sof-ptl-dmic-4ch-id5.bin,DMIC0_ENHANCED_CAPTURE=true,\ | |||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default" | |||
|
|
|||
| # for WCL | |||
There was a problem hiding this comment.
I think I will not update the patch, it is obvious from the code what it does.
|
2.15 candidate |
PR 11161: test resultsRun date: 2026-09-03 11:21 UTC Tested commit: 172e216911023c172f1a9db294143196c51cfc71
|
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Good catch! Seems to be only place where "PLATFORM=wcl" was used. FYI @lgirdwood , definitely v2.15 material, we have shipped these buggy topologies in sof-bin-2025.12.
… fragments
There is no platform as wcl defined since it is identical to PTL. For the DMIC blob creation a correct platform is needed and in case of PLATFORM=wcl, this is not going to happen.
Use the correct PLATFORM=wcl to build working DMIC blobs.