fix(tags): hide git console window on Windows - #324
Merged
EyJunge1 merged 1 commit intoOct 1, 2026
Merged
Conversation
The v2 plugin host runs without a console, so spawning git without `windowsHide` popped a visible console window for every call.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly addresses the reported Windows behavior without affecting other platforms.
Review effort: Balanced
Findings: None
What changed in this PR
Adds Windows child-process hiding to prevent Git console windows flashing during tag collection.
Changes:
- Sets
windowsHide: truefor all Git executions in the tags service. - Preserves existing behavior on macOS and Linux.
| File | Description |
|---|---|
src/services/tags.ts |
Hides Windows console windows for Git child processes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows a black console window flashes at plugin init and again after each session goes idle.
getTags()shells out togitup to five times.Cause
Windows opens a visible console for any child spawned without
CREATE_NO_WINDOWwhen the parent has no console. The OpenCode v2 plugin host runs console-less (opencode serve --service), so these spawns surfaced windows. The host's own shell and snapshotgitspawns pass the flag; this call site didn't.Fix
windowsHide: trueon the plugin's onlychild_processcall site. Covers thegit.cmd/git.batshell path too, no-op on macOS/Linux.Testing
prettier --check src/services/tags.tsRelated: anomalyco/opencode#50868