Conversation
…brary) This happened when scrolling by dragging the scrollbar handle. It was due to not taking into account the first item is Shuffle, which isn't in the songs list. Apply the same fix as in the Albums list.
timusus
pushed a commit
that referenced
this pull request
Sep 24, 2026
#222) The Songs list fast-scroller's popup text lookup indexed directly into the songs list by the scroller's row index, which doesn't account for the leading Shuffle header row. Scrolling to the bottom of the list could index past the end. AlbumList.kt already offsets by 1 for its own Shuffle header; apply the same offset and bounds check here. Changelog: Fixed a crash when fast-scrolling to the bottom of the Songs list
Owner
|
Landed on main as 880b57e (ported onto current main). Verified by unit tests plus the full emulator suite, which now carries a check for this change. Thanks @alexmgraca! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened when scrolling by dragging the scrollbar handle.
It was due to not taking into account the first item is Shuffle, which isn't in the songs list. Apply the same fix as in the Albums list.