Conversation
rivaldi8
force-pushed
the
fix/alexm-exit-selection-mode-on-back-pressed
branch
from
May 6, 2026 17:15
961a6f3 to
5b817c9
Compare
timusus
added a commit
that referenced
this pull request
Sep 24, 2026
…ts (#225) Pressing the system back button while a selection was active exited the whole Library tab instead of clearing the selection. Add a per-Fragment OnBackPressedCallback, disabled by default, that clears selection; enable/disable it alongside the contextual toolbar show/hide in the uiState collector. Genre and Playlist tabs have no selection state, so they're unaffected. Changelog: The back button now exits multi-select mode on the Songs, Albums and Artists tabs instead of leaving the library Co-authored-by: Àlex Magaz Graça <alexandre.magaz@gmail.com>
Owner
|
Landed on main as 8228a00, reworked onto current main, with you credited as co-author. Verified by unit tests plus the full emulator suite, which now carries a check for this change. Thanks! |
timusus
added a commit
that referenced
this pull request
Sep 26, 2026
Songs/Albums/Artists selection persisted across pager tab switches and past navigating away from the Library destination, since all six tab ViewModels share the destination's nav-entry ViewModelStore (#225). LibrarySelectionCoordinator centralises the clearing rule in one place instead of duplicating it into each selectable tab's ViewModel. Closes #456
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements it for Artists, Albums and Songs tabs. Genres and Playlists don't support selecting items. Previously, this would close the application.
Ideally, we should also have a back button (<-) in the selection toolbar doing the same, but I think it's better left until this part is migrated to Compose.