Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialization and checked-collection examples still refer to Python 2's
unicodeandlongbuiltins. On the documented Python 3 versions, those names raiseNameErrorwhile definingPersonandPositives.Use
strfor the name field andintfor the checked set, matching existing tests. Also update the string literal and illustrated serialized value to Python 3 notation. Only four README lines change.Validation: inspected the field/type handling and corresponding declarations in the existing record and checked-set tests. Parsed the two README sections as Python AST without evaluating them and checked that the Python 2-only names are gone. No Pyrsistent import, examples, project tests or documentation build were run.
Prepared with assistance from OpenAI Codex.