Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDeque's unit-step slices currently wrap bounds modulo the deque length instead of clipping them. For example,
pdeque([0, 1, 2])[:3]returns an empty deque and[3:]returns the whole deque; explicit bounds on an empty deque raiseZeroDivisionError.Use
slice.indices()to normalize bounds, then trim the left and right sides with the existing persistent operations. This preserves structural sharing andmaxlen, handles empty/reversed ranges, and follows Python's integer-index protocol.Regression tests compare the results with list slicing across empty, singleton and multi-element inputs, bounded/unbounded deques, negative/out-of-range bounds, and custom/invalid index types. Before the change: 40 failures in the deque suite. After:
The separate maxlen fixes proposed in #331 concern
remove()andreverse()and are unchanged here.