Repository navigation
Retain the latest PSet evolver snapshot - #338
Open
36taransingh5-dotcom wants to merge 2 commits into
Open
36taransingh5-dotcom wants to merge 2 commits into
36taransingh5-dotcom wants to merge 2 commits into
Conversation
Store each newly materialized PSet as the evolver's current snapshot, matching PMap evolver behavior. Repeated persistent calls must not return an older set.
Cover repeated persistent calls after add/remove, a no-op following a snapshot, and sequential immutable snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a PSet evolver is changed and materialized, calling
persistent()again returns the original set instead of the latest snapshot:Materializing the underlying map clears its dirty state, but the set evolver's cached
_original_psetstill refers to the old set.Change
Update the cached set when materializing a dirty evolver, then return that snapshot on subsequent calls. This follows the existing PMap evolver pattern. Add four regression cases covering add/remove snapshots, a no-op after a snapshot, and sequential snapshots that remain independent.
Validation
On Linux, Python 3.12.15:
PYRSISTENT_NO_C_EXTENSION=1: 540 passed, 102 skipped (backend-specific tests).git diff --checkpassed.The published source and tests were read back and the suites rerun against those contents. This fix was found by source inspection and local reproduction, not a reported production incident.
AI assistance was used to investigate, implement, and test this contribution.