Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A nonempty iterable passed to
pdeque(..., maxlen=0)currently remains in the deque. The constructor'st[-maxlen:]becomest[0:], retaining every value. Subsequent appends can then grow the supposedly zero-capacity deque.Use an empty prefix slice for zero bounds while retaining the existing suffix slice for positive bounds. The iterable is still consumed,
Falseretains its accepted integer-zero behavior, and non-integral zero bounds still raiseTypeError.Add six parameterized regressions covering empty, singleton and multi-element generator inputs with
0andFalse, input consumption, length, retained maxlen, both append/extend directions and pickle round trips. Also pin rejection ofmaxlen=0.0. Four new cases fail on the unchanged source; the two empty-input controls pass.Validation on Linux:
PYRSISTENT_NO_C_EXTENSION=1: 542 passed, 102 existing C-extension skips each.git diff --check: passed.The existing Hypothesis collection warning remains. Other Python versions, PyPy, platforms, hosted CI and the memory-profile job were not run locally.
Related to #318, which was closed without a fix. This does not change the remove/reverse maxlen behavior or the separate slicing/rotation proposals.
AI-assisted investigation, implementation and testing.