[fooklook]

Passwords containing spaces fail authentication when PGSync builds database, search, or Redis connection URLs. For example, demo password+with@symbols is encoded with quote_plus and decoded by URL consumers as demo+password+with@symbols.

Use URL percent-encoding (quote(..., safe="")) for passwords in the URL userinfo component, so spaces become %20 and literal plus signs remain %2B. Keep existing auth-plugin precedence and explicit-URL overrides.

Validation:

• Added 12 round-trip regression cases covering database, search, Redis with a username, and Redis with the default user; passwords include spaces, reserved characters, and Unicode.
• Reproduced the failure before applying the fix. All 18 tests in tests/test_urls.py pass after the fix.
• isort --profile black --check-only, black --check, flake8, and git diff --check pass for the changed Python files.

The tests do not require external services. The full database/backend matrix is left to upstream CI.

[toluaina]

thanks for this