Repository navigation
Fix Topgear URL submissions in My Submissions -> master - #2513
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Topgear members opening a challenge's My Submissions tab (
?tab=mine) could get the file uploader whensubmission_type=urlmetadata was absent. Select the existing URL submission flow for challenges identified by either the Topgear hostname or the configured Topgear group, including challenges with legacy ZIP metadata. Other challenges retain their metadata-based selection.Add regression coverage using the real detail page and submission form to verify the deep link, Topgear terms, and direct SharePoint URL submission without file upload. Update the submission-mode documentation.
Validation
yarn test:no-watch --runInBand src/apps/opportunities: 62 suites, 707 tests passed.yarn lint: passed.NODE_OPTIONS=--max-old-space-size=8192 yarn run build: passed. Uses an increased Node heap; the dev build exceeded the default 4 GB limit.Builds report source-map, CSS-order, and bundle-size warnings.
Companion dev PR: #2512