Repository navigation
PM-6555: Show the app drawer for administrators - #420
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes administrator app drawer visibility reported in PM-6555.
UniNav discarded the
administratorJWT role because it was missing from its recognized roles. An administrator who also hadTopcoder Customerwas consequently treated as customer-only: both drawer sections were filtered out and the trigger added in #419 was hidden. An administrator without a recognized navigation role received only the fallback Talent section.Recognize
administrator(including legacy capitalization such asAdministrator) and include it in the Talent and Staff guards. Administrators now receive both sections even when they also have Customer or Talent roles. Customer-only accounts still have no drawer, and application-specific roles such asPayment Admindo not grant Staff navigation. Document the role rules and regenerate TypeScript declarations. Linked applications continue enforcing their own permissions.Validation:
npm test.npm run lint: 0 errors, 0 warnings.npm run build: main and nudge production bundles plus declarations succeed; browser validation uses the checked-in development environment configuration.Browser checks use synthetic JWT/profile fixtures, not mess's live session. QA should retest mess on topcoder-dev.com after deployment. Targets
dev, confirmed as this repository's development branch.